[Lldb-commits] [PATCH] LLDB AddressSanitizer break on error and report data extraction

Jason Molenda jmolenda at apple.com
Fri Oct 10 15:37:25 PDT 2014

Looks good to me. It's not critical but AddressSanitizerRuntime::RetrieveReportData() is more expensive than it needs to be because it's compiling your expression every time.  If this is going to be executed frequently, you'd want to use a ClangFunction - along the lines with how the SystemRuntimeMacOSX calls into libBacktraceRecording (although I did it poorly and I don't think I get the return type from the ClangFunction - I just extract it from memory, probably unnecessarily, I need to go back and look at that again.)

I don't think this code path will be hot enough to be performance sensitive, but that's the only comment I have.  I would commit this patch and if you want to look at switching to a ClangFunction, do that after.


More information about the lldb-commits mailing list