[Lldb-commits] [PATCH] Add "target.jit-args" settings

[Enrico Granata]

Thanks Todd (&Alex)!

> On Oct 8, 2014, at 11:13 AM, Todd Fiala <tfiala at google.com> wrote:
> 
> I've got Alex Pepper looking into this later today.
> 
> On Wed, Oct 8, 2014 at 10:23 AM, Enrico Granata <egranata at apple.com <mailto:egranata at apple.com>> wrote:
> Nope it just worked around the test failure
> I didn't want the noise of the failing test, but I was making changes in that area so I cared enough that I wouldn't regress functionality.
> So that's the rationale for my workaround. The bug is still there. It's a minor bug but it's there. 
> 
> Sent from my iPhone
> 
> On Oct 8, 2014, at 9:10 AM, Todd Fiala <tfiala at google.com <mailto:tfiala at google.com>> wrote:
> 
>> Drats.
>> 
>> Enrico, did your recent commit fix that?
>> 
>> On Tue, Oct 7, 2014 at 3:59 PM, Enrico Granata <egranata at apple.com <mailto:egranata at apple.com>> wrote:
>> Heads up. This patch seems to be the cause of http://llvm.org/bugs/show_bug.cgi?id=21190 <http://llvm.org/bugs/show_bug.cgi?id=21190>
>> 
>> Essentially, the command parser gets confused with commands like:
>> type summary add Rectangle --summary-string "Category1" -w Category1
>> 
>> and the value for the -w option ends up being ategory1 with the leading C chopped away
>> 
>>> On Oct 6, 2014, at 4:23 PM, Todd Fiala <tfiala at google.com <mailto:tfiala at google.com>> wrote:
>>> 
>>> svn commit
>>> Sending        include/lldb/Expression/ClangExpressionParser.h
>>> Sending        include/lldb/Target/Target.h
>>> Sending        source/Expression/ClangExpressionParser.cpp
>>> Sending        source/Expression/ClangFunction.cpp
>>> Sending        source/Expression/ClangUserExpression.cpp
>>> Sending        source/Expression/ClangUtilityFunction.cpp
>>> Sending        source/Interpreter/Args.cpp
>>> Sending        source/Target/Target.cpp
>>> Transmitting file data ........
>>> Committed revision 219169.
>>> 
>>> http://reviews.llvm.org/D5472 <http://reviews.llvm.org/D5472>
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at cs.uiuc.edu <mailto:lldb-commits at cs.uiuc.edu>
>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits <http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits>
>> 
>> Thanks,
>> - Enrico
>> 📩 egranata@.com ☎️ 27683
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> -- 
>> Todd Fiala |	 Software Engineer |	 tfiala at google.com <mailto:tfiala at google.com>	
>> 
> 
> 
> 
> -- 
> Todd Fiala |	 Software Engineer |	 tfiala at google.com <mailto:tfiala at google.com>	
> 

Thanks,
- Enrico
📩 egranata@.com ☎️ 27683




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141008/939fed03/attachment.html>