[Lldb-commits] [PATCH] lldb incorrectly parses DWARF information from Go binary

Greg Clayton clayborg at gmail.com
Wed Oct 8 10:55:12 PDT 2014

I would suggest still giving the __DWARF segment a valid vm address range and giving each section within that a valid addr + size that falls within the __DWARF segment's vm range.

After looking at your fix, the patch will work. Feel free to rename the Section::GetOffset() to Section::GetMemoryOffset() to make things clearer. We already have Section::GetFileOffset(), so it would be nice to specify "Memory" in GetMemoryOffset() to make sure things are clear from a Section API perspective.

Other than that, the patch does look like it will work just fine.


More information about the lldb-commits mailing list