[Lldb-commits] [PATCH] Add "target.jit-args" settings

[jingham at apple.com]

The argument parsing part of this patch doesn't work correctly.  It changes all quoted values in the command input from options to arguments  For instance, I have this command in my .lldbinit:

type summary add -w lldb "lldb::ModuleSP" -s "${var.__ptr_%S}"

Your patch notices that "${var.__ptr_%S}" has quotes around it, so it removes it from the option parsing.  But since the -s requires an argument value, the command no longer parses correctly.

Jim

> On Sep 30, 2014, at 11:27 AM, Tong Shen <endlessroad at google.com> wrote:
> 
> Address Jim's comments
> 
> - Rename jit-args to expr-parser-compiler-args.
> - Add a common functionality for Args: if one argument is surrounded by quote char, don't consider it as an command option.
> 
> http://reviews.llvm.org/D5472
> 
> Files:
>  include/lldb/Expression/ClangExpressionParser.h
>  include/lldb/Target/Target.h
>  source/Expression/ClangExpressionParser.cpp
>  source/Expression/ClangFunction.cpp
>  source/Expression/ClangUserExpression.cpp
>  source/Expression/ClangUtilityFunction.cpp
>  source/Interpreter/Args.cpp
>  source/Target/Target.cpp
> <D5472.14238.patch>