[Lldb-commits] [PATCH] Make llgs build on Android. No functionality changes.

[Tong Shen]

Eventually there should be separate files for Android.

I just want to post a quick patch to let it build on Android first.

Cleanups on the way.

================
Comment at: source/Host/common/Host.cpp:978-980
@@ -957,2 +977,5 @@
     }
+#else
+    error.SetErrorString("Host::LaunchProcessPosixSpawn() not supported on Android");
+#endif
 
----------------
zturner wrote:
> If launching a process via posix_spawn() isn't supported on Android, then how *do* you launch a process on Android?
No launching; attaching only.

================
Comment at: source/Host/posix/HostInfoPosix.cpp:98-100
@@ -96,2 +97,5 @@
     group_name.clear();
+#else
+    assert(false && "getgrgid_r() not supported on Android");
+#endif
     return NULL;
----------------
zturner wrote:
> Is this unsupported on Android because it doesn't compile, or for some other reason?  Also, Android implies Linux right?  If so, this check is better in HostInfoLinux
Android uses its own C library, which does not provide getgrgid_r()

================
Comment at: source/Host/posix/HostThreadPosix.cpp:53-58
@@ -52,4 +52,8 @@
     Error error;
+#ifndef __ANDROID__
     int err = ::pthread_cancel(m_thread);
     error.SetError(err, eErrorTypePOSIX);
+#else
+    error.SetErrorString("HostThreadPosix::Cancel() not supported on Android");
+#endif
 
----------------
zturner wrote:
> Same as before.  Is this unsupported because it doesn't compile, or for some other reason?  Also more appropriate in HostThreadLinux.
Same as before

http://reviews.llvm.org/D5495