[Lldb-commits] [PATCH] Make llgs build on Android. No functionality changes.

[Zachary Turner]

================
Comment at: source/Host/common/Host.cpp:978-980
@@ -957,2 +977,5 @@
     }
+#else
+    error.SetErrorString("Host::LaunchProcessPosixSpawn() not supported on Android");
+#endif
 
----------------
If launching a process via posix_spawn() isn't supported on Android, then how *do* you launch a process on Android?

================
Comment at: source/Host/posix/HostInfoPosix.cpp:98-100
@@ -96,2 +97,5 @@
     group_name.clear();
+#else
+    assert(false && "getgrgid_r() not supported on Android");
+#endif
     return NULL;
----------------
Is this unsupported on Android because it doesn't compile, or for some other reason?  Also, Android implies Linux right?  If so, this check is better in HostInfoLinux

================
Comment at: source/Host/posix/HostThreadPosix.cpp:53-58
@@ -52,4 +52,8 @@
     Error error;
+#ifndef __ANDROID__
     int err = ::pthread_cancel(m_thread);
     error.SetError(err, eErrorTypePOSIX);
+#else
+    error.SetErrorString("HostThreadPosix::Cancel() not supported on Android");
+#endif
 
----------------
Same as before.  Is this unsupported because it doesn't compile, or for some other reason?  Also more appropriate in HostThreadLinux.

http://reviews.llvm.org/D5495