[Lldb-commits] [PATCH] Make llgs build on Android. No functionality changes.

[Tong Shen]

Got it, on it now :-)

Thanks Jim!

On Thu, Sep 25, 2014 at 4:37 PM,  <jingham at apple.com> wrote:
> Uses in the Host/Common seem okay to me, they already contain other defines distinguishing among the various Unixes.  I didn't look closely at the others.  I'd rather you didn't add a bunch of #ifndef __ANDROID__ for the IOHandler that will just have to come out shortly, but get one patch that does this right.
>
> Thanks!
>
> Jim
>
>
>> On Sep 25, 2014, at 4:30 PM, Tong Shen <endlessroad at google.com> wrote:
>>
>> Thanks for the comment, Jim!
>>
>> IOHandlerEditLine:
>> Yes there's no need to use IOHandlerEditLine in that place; it just
>> parses commands and execute them.
>> I will come up with a new subclass of IOHandler and replace
>> IOHandlerEditLine there.
>> Can I do that in a follow-up patch, or do you prefer I do it in this patch?
>>
>> Python goo:
>> Sure, I will use LLDB_DISABLE_PYTHON.
>>
>> Other uses:
>> Are you strongly against any other use of __ANDROID__?
>>
>>
>> On Thu, Sep 25, 2014 at 4:23 PM,  <jingham at apple.com> wrote:
>>> I don't have time to look at this right now, but that's an awful lot of #ifndef __ANDROID__ in places I wouldn't really expect these defines.  Particularly the ones that deal with the IOHandlerEditLine.  Either you're building stuff for llgs that you don't really need to (why does it need the command interpreter) or we really need a non-interactive configuration for the command interpreter that substitutes the EditLine I/O handler with one that is not interactive...  Anyway, that part does seem ugly to me.
>>>
>>> Also one of the uses of __ANDROID__ is to not include some python goo, but there's already a "build without python" define for that purpose.
>>>
>>> Jim
>>>
>>>
>>>> On Sep 25, 2014, at 4:15 PM, Todd Fiala <tfiala at google.com> wrote:
>>>>
>>>> LGTM.
>>>>
>>>> We might later want to look at how/where we're constructing IOHandlerEditLine.  It seems like it might first show up at too low a level of the stack based on your need to comment it out (unneeded in llgs and not wanting to bring in the libedit dependency).
>>>>
>>>> I'll ping Greg to see if he wants somebody to look over before we approve and move this in.
>>>>
>>>> http://reviews.llvm.org/D5495
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> lldb-commits mailing list
>>>> lldb-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>>
>>
>>
>>
>> --
>> Best Regards, Tong Shen
>



-- 
Best Regards, Tong Shen