[Lldb-commits] [PATCH] Make llgs build on Android. No functionality changes.

[Todd Fiala]

I think part of our challenge is when we try to build remote pieces with
what is effectively lldb-core, we really could use at least a 2-layer
division of the core.  The true low-level goo in a core, and some
higher-level bits that only the lldb client really needs but isn't needed
for a debug stub/monitor.

On Thu, Sep 25, 2014 at 4:23 PM, Jim Ingham <jingham at apple.com> wrote:

> I don't have time to look at this right now, but that's an awful lot of
> #ifndef __ANDROID__ in places I wouldn't really expect these defines.
> Particularly the ones that deal with the IOHandlerEditLine.  Either you're
> building stuff for llgs that you don't really need to (why does it need the
> command interpreter) or we really need a non-interactive configuration for
> the command interpreter that substitutes the EditLine I/O handler with one
> that is not interactive...  Anyway, that part does seem ugly to me.
>
> Also one of the uses of __ANDROID__ is to not include some python goo, but
> there's already a "build without python" define for that purpose.
>
> Jim
>
> http://reviews.llvm.org/D5495
>
>
>


-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140925/77de18f9/attachment.html>