[Lldb-commits] [PATCH] More conversions of off_t to lldb::offset_t for llvm trunk

[Hin-Tak Leung]

Hi Greg and all,

>From the lldm-dev thread below, I assume it is okay to ask you to review
the attached and commit on my behalf.

My main interest is really to get a more up-to-date llvmpipe mesa gallium driver
for my new graphics hardware. To keep the 32-bit mesa packages
in-sync with the 64-bit ones, I needed 32-bit llvm (and a more up-to-date one
than shipped by fedora 20) too; I don't really use 32-bit llvm directly to any extent.
That said, the rpm packaging system does
(after ./configure ... --disable-expensive-checks ...), as far as I see,
 make -k check ...
 make -C tools/clang/test ...
and abort on failures, so there is some assurance the compilation is correct.

The changes were made against llvm 3.4.x; part of it is already in trunk,
so I am preparing two patches (with the smaller trunk one not tested); both are fairly
self-evident anyhow.

Note that to finish the rpm packaging, there is an additional dependency: 
(https://bugzilla.redhat.com/show_bug.cgi?id=1144863)
That's just FYI, not really relevant to llvm development.

This is the trunk patch; the llvm 3.4.x patch to follow.

Hin-Tak

----
This is the set of changes I need to make to build 32-bit llvm on
fedora 20 x86_64 (to get 32-bit mesa llvmpipe Gallium drm driver), against
llvm 3.4.2.

Similar problems were apparently seen with Ubuntu 11.04 32bit and
Ubuntu 12.04 32-bit in the thread leading up to this post:

http://lists.cs.uiuc.edu/pipermail/lldb-dev/2013-February/001470.html

and was worked around, but didn't get addressed.

Part of the changes I need is already part of:

commit 6201a1a109e4c43ece8dbcc81571f1d095bca6d3
Author: Zachary Turner <zturner at google.com>
Date:   Wed Jul 2 17:24:07 2014 +0000

    Start converting usages of off_t to other types.

So I am preparing two patches, one for trunk and one for 3.4.x.

This is the for-trunk patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-More-conversions-of-off_t-to-lldb-offset_t-for-llvm-trunk-.patch
Type: text/x-patch
Size: 6354 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140921/dfa87b35/attachment.bin>