[Lldb-commits] [PATCH] find global by regex in SBTarget

[Carlo Kok]

On Fri, 19 Sep 2014 20:18:51 +0200, <jingham at apple.com> wrote:

> I think the enum you added goes in "lldb-enumerations.h" not in  
> SBTarget.h.

Ah yes.
>
> Also, I wouldn't use the regex match for the straight match, since that  
> is much less efficient than the ConstString ==, which is just a pointer  
> compare.  In the fullness of time, we would retire the version that  
> doesn't take a MatchType, so we don't want that version to be less  
> efficient.

Done.

> Also, again, don't forget to add the new definition from SBTarget.h to  
> SBTarget.i or the new API won't be available in Python.


Ah yes, forgot to include that file in the patch. I couldn't file a .i for  
the enumerations though, I'm not familiar enough with swig to know for  
sure, but that might get pulled in automatically?


-- 
Carlo Kok
RemObjects Software
-------------- next part --------------
A non-text attachment was scrubbed...
Name: find-globals-by-regex3.patch
Type: application/octet-stream
Size: 8629 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140919/9e610b09/attachment.obj>