[Lldb-commits] [PATCH] lldb more verbose "invalid frame" error

Jason Molenda jmolenda at apple.com
Wed Sep 17 20:14:17 PDT 2014


This looks like a good change, thank you for coming up with it.  Could you put the statements on separate lines from the conditional expressions?  Instead of

if (!m_exe_ctx.HasTargetScope()) result.AppendError (GetInvalidTargetDescription());

more like this -

if (!m_exe_ctx.HasTargetScope()) 
    result.AppendError (GetInvalidTargetDescription());

or

if (!m_exe_ctx.HasTargetScope())
{
    result.AppendError (GetInvalidTargetDescription());
}

(in this case I think not using the braces will look cleaner).  I know we have a few examples of the if (cond) stmt; in lldb already but they are something we need to clean up at some point.

J

http://reviews.llvm.org/D5374






More information about the lldb-commits mailing list