[Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

[Kuba Brecka]

> Getting closer.
Thanks for the patience :)

> Why not internal_strncpy(descr->name, vars[i].name_pos, Min(descr->name_size - 1, vars[i].name_len)) ?
Because that would not write \0 after the string (we're copying just a part of the string pointed to by vars[i].name_pos). So I would have to memset the whole buffer to zero before. Should I do that, instead of the strncat? (The strncat is also used in asan_report.cc:436).

http://reviews.llvm.org/D4527

Files:
  include/sanitizer/asan_interface.h
  lib/asan/asan_debugging.cc
  lib/asan/asan_globals.cc
  lib/asan/asan_interface_internal.h
  lib/asan/asan_report.cc
  lib/asan/asan_report.h
  test/asan/TestCases/debug_locate.cc
  test/asan/TestCases/debug_report.cc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4527.13669.patch
Type: text/x-patch
Size: 18824 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140913/bde3b918/attachment.bin>