[Lldb-commits] [PATCH] Check for byte order correctness in GDBRemoteCommunicationClient::GetCurrentProcessInfo.

[Todd Fiala]

My pleasure!

On Fri, Sep 12, 2014 at 1:38 PM, Stephane Sezer <sas at fb.com> wrote:

> Thanks a lot, Todd :)
>
> On Sep 12, 2014, at 10:09 AM, Todd Fiala <tfiala at google.com> wrote:
>
> > I'm going to go ahead and get this in since I didn't hear any feedback.
> >
> > (Working through your backlog of patches, Stephane...)
> >
> > On Fri, Sep 5, 2014 at 8:11 AM, Todd Fiala <tfiala at google.com> wrote:
> > This looks reasonable; however, I’d like to hear the Apple guys since
> I’m not sure if there’s any case for their hardware where this line
> wouldn’t be true:
> >
> >                 if
> >  (byte_order != eByteOrderInvalid)
> >                 {
> >                     assert (byte_order == m_process_arch.GetByteOrder());
> >                 }
> >
> > -Todd
> >
> > ​
> >
> >
> > On Thu, Sep 4, 2014 at 3:38 PM, Stephane Sezer <sas at fb.com> wrote:
> > This is useful for checking inconsistencies between what the remote
> debug server thinks we are debugging and we think we are debugging. This
> follows the check for pointer byte size done just above.
> >
> >
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
> >
> >
> >
> >
> > --
> > Todd Fiala |   Software Engineer |     tfiala at google.com |
> 650-943-3180
> >
> >
> >
> >
> > --
> > Todd Fiala |   Software Engineer |     tfiala at google.com |
> 650-943-3180
> >
>
>


-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140912/a60a833b/attachment.html>