[Lldb-commits] [PATCH] [lldb] Abstract a superclass for a generic thread container

[jingham at apple.com]

We indent the initializer list in constructors, so not:

+ThreadCollection::ThreadCollection() :
+m_threads(),
+m_mutex()
+{
+}
+
+ThreadCollection::ThreadCollection(collection threads) :
+m_threads(threads),
+m_mutex()
+{
+}
+

But what you see in ThreadList:

 ThreadList::ThreadList (Process *process) :
+    ThreadCollection(),
     m_process (process),
     m_stop_id (0),
-    m_threads(),
     m_selected_tid (LLDB_INVALID_THREAD_ID)

Other than that, looks fine.

Jim


> On Sep 5, 2014, at 11:34 AM, Kuba Brecka <kuba.brecka at gmail.com> wrote:
> 
> Addressing http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140901/012796.html
> 
> http://reviews.llvm.org/D5200
> 
> Files:
>  include/lldb/Target/ThreadCollection.h
>  include/lldb/Target/ThreadList.h
>  include/lldb/lldb-forward.h
>  lldb.xcodeproj/project.pbxproj
>  source/Target/ThreadCollection.cpp
>  source/Target/ThreadList.cpp
> <D5200.13333.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits