[Lldb-commits] [PATCH] [lldb] ASan history threads SB API

Jason Molenda jmolenda at apple.com
Wed Sep 3 14:38:01 PDT 2014


This looks fine to me - but Jim/Enrico/Greg may want to comment.

One thing I'd change is that you document the SBValue::GetNumMemoryHistoryThreads and SBValue::GetMemoryHistoryThreadAtIndex in include/lldb/API/SBValue.h but not in scripts/Python/interface/SBValue.i.  The generated documentation for the SB APIs are all based on the .i file comments -- e.g. when you do "script help (lldb.SBValue)" in lldb, that stuff all comes out of the SBValue.i header.

http://reviews.llvm.org/D5175






More information about the lldb-commits mailing list