[Lldb-commits] [PATCH] lldb more on register context arm64

Paul Osmialowski pawelo at king.net.pl
Sun Aug 31 02:12:32 PDT 2014


Corrected version, overhead 'if (success)' removed - it consisted of two if's, first was anded with (reg_info->byte_offset & 0x1) which can never be true on ARM64, second 'if' can never be true because first 'if' action would never happen.
Note that my RegisterContextPOSIXProcessMonitor_arm64.cpp file was based on RegistertContextPOSIXProcessMonitor_mips64.cpp which contains the same mistake and the same comment with x86 register names, I guess it was copy-pasted from x86 implementation.

http://reviews.llvm.org/D5089

Files:
  source/Plugins/Process/POSIX/CMakeLists.txt
  source/Plugins/Process/POSIX/POSIXThread.cpp
  source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_arm64.cpp
  source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_arm64.h
  source/Plugins/Process/Utility/CMakeLists.txt
  source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp
  source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5089.13127.patch
Type: text/x-patch
Size: 31130 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140831/9b90ed2a/attachment.bin>


More information about the lldb-commits mailing list