[Lldb-commits] Review request on Darwin side of change

[Todd Fiala]

(And thanks for checking it out!)


On Fri, Aug 29, 2014 at 7:46 AM, Todd Fiala <tfiala at google.com> wrote:

> > Is this necessary in RegisterInfos_arm64.h?
> > +#include "../../../Utility/ARM64_GCC_Registers.h"
> >+#include "../../../Utility/ARM64_DWARF_Registers.h"
>
> I'll have a look at that before submitting.  If nothing else, the ../../..
> doesn't need to be there.  (He may have been copying some of my early code
> before I grok'd how all the paths were set up --- I'll fix those too if I
> find them.).
>
>
>
> On Fri, Aug 29, 2014 at 12:37 AM, Jason Molenda <jason at molenda.com> wrote:
>
>> Looks good to me, please commit.  I'll be the one who has to fix it if
>> our arm64 back end is broken :) but I don't anticipate any problems.
>>
>> Is this necessary in RegisterInfos_arm64.h?
>>
>> +#include "../../../Utility/ARM64_GCC_Registers.h"
>> +#include "../../../Utility/ARM64_DWARF_Registers.h"
>>
>> The previous RegisterContext_arm64 just included these as
>> "ARM64_GCC_Registers.h" without any directory paths - the cmake/xcode
>> configurations must have put the source/Utility directory in the list of
>> include directories?
>>
>> J
>>
>>
>> On Aug 28, 2014, at 7:57 AM, Todd Fiala <tfiala at google.com> wrote:
>>
>> > Attaching the final diff I'm using over here (needed minor rebasing
>> against TOT, r216668).
>> >
>> >
>> > On Thu, Aug 28, 2014 at 7:40 AM, Todd Fiala <tfiala at google.com> wrote:
>> > Hey Greg and Jim,
>> >
>> > Can I get somebody on the Apple side to review the Darwin side of this
>> change?
>> >
>> > http://reviews.llvm.org/D4580
>> >
>> > He's refactored some of the arm64 code in the Darwin register context
>> to use a common header that he's also referencing on the Linux register
>> context work.  Since I recall hearing darwin and Linux handle some arm
>> registers slightly differently (at least in the Thumb case), I want to make
>> sure the sharing doesn't introduce bugs in that area.
>> >
>> > I'll be testing the  D4580 change in a minute here when I'm done with
>> D4381.  If I have to do heavy rebasing, I'll post the updated patch here.
>> (It's from a while back now).
>> >
>> > Thanks!
>> >
>> > --
>> > Todd Fiala |   Software Engineer |     tfiala at google.com |
>> 650-943-3180
>> >
>> >
>> >
>> >
>> > --
>> > Todd Fiala |   Software Engineer |     tfiala at google.com |
>> 650-943-3180
>> >
>> >
>> <pawelo_reg_context_arm64_rebase_r216668.diff>_______________________________________________
>> > lldb-commits mailing list
>> > lldb-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>
>>
>
>
> --
> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140829/89fb7f06/attachment.html>