[Lldb-commits] [PATCH] Implements a HostThread class.

Zachary Turner zturner at google.com
Thu Aug 28 14:51:26 PDT 2014


Hi majnemer, rnk, emaste, tfiala,

This class implements a host thread for the different platforms.  As with HostProcess, no code has been updated to use HostThread yet, as this will clutter up the code review unnecessarily.  However, the methods of HostThread generally map to methods of Host, so the conversion should be mostly mechanical.  Because the actual conversion of client code has not been updated to use HostThread yet, it means the code in HostThread is largely duplicated.  This duplication will be removed after the transition takes place.

I'm not super good at Linux, MacOSX, or FreeBSD, so I've included various people as reviewers in hopes of catching anything I may have implemented incorrectly.  But don't feel obligated to review everything.

I've compiled and tested these changes on Mac, Linux, and Windows.  (note, however, since nobody has been updated to use HostThread yet, there's little to actually test).

http://reviews.llvm.org/D5110

Files:
  include/lldb/Core/DataBuffer.h
  include/lldb/Host/HostThread.h
  include/lldb/Host/freebsd/HostThreadFreeBSD.h
  include/lldb/Host/linux/HostThreadLinux.h
  include/lldb/Host/macosx/HostThreadMacOSX.h
  include/lldb/Host/posix/HostThreadPosix.h
  include/lldb/Host/windows/HostThreadWindows.h
  include/lldb/lldb-types.h
  lldb.xcodeproj/project.pbxproj
  source/Host/CMakeLists.txt
  source/Host/common/Host.cpp
  source/Host/freebsd/Host.cpp
  source/Host/freebsd/HostThreadFreeBSD.cpp
  source/Host/linux/Host.cpp
  source/Host/linux/HostThreadLinux.cpp
  source/Host/macosx/Host.mm
  source/Host/macosx/HostThreadMacOSX.cpp
  source/Host/posix/HostThreadPosix.cpp
  source/Host/windows/HostThreadWindows.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5110.13058.patch
Type: text/x-patch
Size: 44276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140828/834421d6/attachment.bin>


More information about the lldb-commits mailing list