[Lldb-commits] [lldb] r216028 - Attempt to keep the Linux build happy in face of my changes. Non-Apple folks, can you confirm that this is good enough to keep things building for you?

[Enrico Granata]

Awesome!
If any other build system in use has issues, hopefully the patch is self-explanatory, but please let me know and I will try and help!

> On Aug 19, 2014, at 3:13 PM, Todd Fiala <tfiala at google.com> wrote:
> 
> Hey Enrico,
> 
> A rebuild worked fine (which did a new cmake step).
> 
> I'm in the middle of a clean build, but the cmake step passed.  Usually that's the part that will bark if there's an issue.  I think you're fine as far as cmake builds are concerned.
> 
> -Todd
> 
> 
> On Tue, Aug 19, 2014 at 3:06 PM, Todd Fiala <tfiala at google.com <mailto:tfiala at google.com>> wrote:
> I'll verify on Linux.
> 
> 
> On Tue, Aug 19, 2014 at 2:48 PM, Enrico Granata <egranata at apple.com <mailto:egranata at apple.com>> wrote:
> Author: enrico
> Date: Tue Aug 19 16:48:27 2014
> New Revision: 216028
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=216028&view=rev <http://llvm.org/viewvc/llvm-project?rev=216028&view=rev>
> Log:
> Attempt to keep the Linux build happy in face of my changes. Non-Apple folks, can you confirm that this is good enough to keep things building for you?
> 
> Modified:
>     lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeLists.txt
> 
> Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeLists.txt?rev=216028&r1=216027&r2=216028&view=diff <http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeLists.txt?rev=216028&r1=216027&r2=216028&view=diff>
> ==============================================================================
> --- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeLists.txt (original)
> +++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeLists.txt Tue Aug 19 16:48:27 2014
> @@ -7,4 +7,6 @@ add_lldb_library(lldbPluginAppleObjCRunt
>    AppleObjCTrampolineHandler.cpp
>    AppleObjCTypeVendor.cpp
>    AppleThreadPlanStepThroughObjCTrampoline.cpp
> +  AppleObjCClassDescriptorV2.cpp
> +  AppleObjCTypeEncodingParser.cpp
>    )
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu <mailto:lldb-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits <http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits>
> 
> 
> 
> -- 
> Todd Fiala |	 Software Engineer |	 tfiala at google.com <mailto:tfiala at google.com> |	 650-943-3180 <>
> 
> 
> 
> -- 
> Todd Fiala |	 Software Engineer |	 tfiala at google.com <mailto:tfiala at google.com> |	 650-943-3180 <>

Thanks,
- Enrico
📩 egranata@.com ☎️ 27683




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140819/cbd3fbbf/attachment.html>