[Lldb-commits] [PATCH] Add process launch --enable-aslr option, tweak handling of flag

[jingham at apple.com]

I don't think we have any other instances where we use two flags to express "do x" and "don't do x".  For the long options is isn't such a big deal but we try not to use up more short options than necessary, since this gets to be a crowded space.  Maybe "process launch --enable-aslr <true/false>", which mirrors the setting anyway?

Jim

> On Aug 17, 2014, at 10:48 PM, Todd Fiala <todd.fiala at gmail.com> wrote:
> 
> This change modifies the logic used to set the eLaunchFlagDisableASLR ProcessLaunchInfo setting for inferior process launching.  Now, if 'process launch' is provided with either --disable-aslr or --enable-aslr, then the launch flag is set accordingly.  If niether --disable-aslr or --enable-aslr are specified, then the setting for target.disable-aslr is used to determine the setting or clearing of the eLaunchFlagDisableASLR setting.  The target.disable-aslr setting currently defaults to true, so the default behavior when nothing is specified on the 'process launch' (i.e. 'run' command) is to disable ASLR.
> 
> -- 
> -Todd
> <tfiala_enable-aslr.diff>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits