[Lldb-commits] [PATCH] Make FileAction not be a nested class, and move AddPosixSpawnFileAction from ProcessLaunchInfo to Host.

[Zachary Turner]

Previously FileAction was nested in ProcessLaunchInfo.  This patch moves it into its own header file.  This allows us to move the AddPosixSpawnFileAction function into Host, instead of being in Target.  This was causing problems previously, because it required LLDB_DISABLE_POSIX to be checked from a header file, which put a burden on programmers to remember to #include Host/Config.h before including ProcessLaunchInfo, which kind of doesn't make sense and violates the Host / Target layer separation.

Since whether posix_spawn can be used is inherently host-specific, it makes more sense for this functionality to live inside of Host, which is what this patch addresses.

http://reviews.llvm.org/D4877

Files:
  include/lldb/Host/Host.h
  include/lldb/Target/FileAction.h
  include/lldb/Target/ProcessLaunchInfo.h
  source/Host/common/Host.cpp
  source/Host/macosx/Host.mm
  source/Plugins/Process/Linux/NativeProcessLinux.cpp
  source/Plugins/Process/POSIX/ProcessPOSIX.cpp
  source/Plugins/Process/POSIX/ProcessPOSIX.h
  source/Plugins/Process/Windows/ProcessWindows.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Target/CMakeLists.txt
  source/Target/FileAction.cpp
  source/Target/Process.cpp
  source/Target/ProcessLaunchInfo.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4877.12423.patch
Type: text/x-patch
Size: 27164 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140812/c3c7ee00/attachment.bin>