[Lldb-commits] [PATCH] Handle unexpected output in test output

Ed Maste emaste at freebsd.org
Mon Aug 4 06:33:14 PDT 2014

Hi gkistanova,

LitTestCommand has a set of descriptions for test result codes, and ends up throwing an exception if an unexpected result is somehow reported.

For example, see the FreeBSD buildbot:

We've been running the patch in this review on the FreeBSD-specific buildbot:



Index: zorg/buildbot/commands/LitTestCommand.py
--- zorg/buildbot/commands/LitTestCommand.py
+++ zorg/buildbot/commands/LitTestCommand.py
@@ -140,7 +140,10 @@
   def describe(self, done=False):
     description = Test.describe(self, done)
     for name, count in self.logObserver.resultCounts.iteritems():
-        description.append('{0} {1}'.format(count, self.resultNames[name]))
+        if name in self.resultNames:
+            description.append('{0} {1}'.format(count, self.resultNames[name]))
+        else
+            description.append('Unexpected test result output ' + name)
     return description
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4775.12158.patch
Type: text/x-patch
Size: 687 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140804/11e0421d/attachment.bin>

More information about the lldb-commits mailing list