[Lldb-commits] Remove the use of mkstemp, as it's not portable

Zachary Turner zturner at google.com
Fri Aug 1 10:23:10 PDT 2014


Normally I'd either wait longer for a review (I heard things are hectic
right now) or just submit this patch (doesn't seem very risky), but the
Windows build is currently broken without it, and it modifies the public
API which I've never done before, so I want to make sure this is ok.  I'm
pretty sure it's fine, since all I've done is added a new method to the
public api, but still better safe than sorry.

On Thu, Jul 31, 2014 at 1:46 PM, Zachary Turner <zturner at google.com> wrote:

> Sorry, here's a more easily digestable patch.
> On Thu, Jul 31, 2014 at 1:45 PM, Zachary Turner <zturner at google.com>
> wrote:
>> mkstemp doesn't exist on Windows.  LLVM already has a support function
>> which is the same in spirit as mkstemp.  This patch adds a method to the
>> host layer to create a temporary file, and the implementation of this
>> method on the private side delegates to the corresponding LLVM support
>> function.
>> This fixes the build on Windows and should have identical semantics on
>> other platforms, but please verify.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140801/58a9b9fc/attachment.html>

More information about the lldb-commits mailing list