[Lldb-commits] [PATCH] Makefile.rules: Translate /usr/bin/cc to /usr/bin/c++

[Todd Fiala]

I'm happy to see cleaner code here if it can be written to not re-introduce
the bug.

I don't like programming in make, so I'm happy for somebody else to try
that out :-P


On Wed, Jul 30, 2014 at 1:46 PM, Zachary Turner <zturner at google.com> wrote:

> Could that be fixed by just passing the path to basename() first?
>
>
> On Wed, Jul 30, 2014 at 1:34 PM, Todd Fiala <tfiala at google.com> wrote:
>
>> Hey David,
>>
>> I think I had to touch that code back in November-ish 2013 to deal with
>> an issue where, if the compiler basename appeared in a directory portion of
>> the path (e.g. /usr/local/gcc-4.9.1/bin/gcc), bad things would happen
>> (which I fixed up).  Have you tested this change with a case of the
>> compiler name embedded within the directory?  That would be great.
>>
>> Thanks!
>>
>> -Todd
>>
>>
>> On Wed, Jul 30, 2014 at 1:30 PM, Zachary Turner <zturner at google.com>
>> wrote:
>>
>>> Looks ok to me
>>>
>>>
>>> On Wed, Jul 30, 2014 at 1:12 PM, David Majnemer <
>>> david.majnemer at gmail.com> wrote:
>>>
>>>> Ping.
>>>>
>>>> http://reviews.llvm.org/D4679
>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>>  Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>>
>
>


-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140730/fed97ddb/attachment.html>