[Lldb-commits] [lldb] r214138 - Fixup TestStepNoDebug to cleanup properly on shutdown.

Todd Fiala todd.fiala at gmail.com
Mon Jul 28 15:53:50 PDT 2014


Author: tfiala
Date: Mon Jul 28 17:53:49 2014
New Revision: 214138

URL: http://llvm.org/viewvc/llvm-project?rev=214138&view=rev
Log:
Fixup TestStepNoDebug to cleanup properly on shutdown.

This was causing core dumps on MacOSX and was not properly
cleaning up the state of the inferior before exiting.

The test was overriding def tearDown(), but failed to
call the base class after doing its own cleanup.  This
essentially eliminated normal clean-up activity.

Modified:
    lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py

Modified: lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py?rev=214138&r1=214137&r2=214138&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py (original)
+++ lldb/trunk/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py Mon Jul 28 17:53:49 2014
@@ -74,6 +74,7 @@ class ReturnValueTestCase(TestBase):
 
     def tearDown (self):
         self.dbg.HandleCommand ("settings set target.process.thread.step-out-avoid-nodebug false")
+        TestBase.tearDown(self)
 
     def hit_correct_line (self, pattern):
         target_line = line_number (self.main_source, pattern)
@@ -104,7 +105,7 @@ class ReturnValueTestCase(TestBase):
         threads = lldbutil.get_threads_stopped_at_breakpoint (self.process, inner_bkpt)
         self.assertTrue(len(threads) == 1, "Stopped at inner breakpoint.")
         self.thread = threads[0]
-    
+
     def do_step_out_past_nodebug(self):
         # The first step out takes us to the called_from_nodebug frame, just to make sure setting
         # step-out-avoid-nodebug doesn't change the behavior in frames with debug info.





More information about the lldb-commits mailing list