[Lldb-commits] [PATCH] Improvement for lldb-gdb-remote.txt qHostInfo documentation

[Jason Molenda]

IMO we should change the implementation and the documentation for qHostInfo triple to not specify/use hex encoded strings.  debugserver doesn't send triple.  I don't know about llgs or how much work it would be to change the kalimba gdbserver stub.

> On Jul 24, 2014, at 1:39 PM, Jason Molenda <jmolenda at apple.com> wrote:
> 
> The change to make the documentation match the implementation is fine.
> 
> But I don't see why the triple is sent hex encoded.  The comment & hex encoding was added in r128193 from March 23 2011 by Greg Clayton.  AFAIK '-' is not special in gdb-remote protocol.  Characters that can be a problem are $, #, *, }.
> 
> Greg?
> 
> J
> 
> 
>> On Jul 23, 2014, at 6:23 AM, Matthew Gardiner <mg11 at csr.com> wrote:
>> 
>> Folks,
>> 
>> When I first implemented the qHostInfo for the kalimba gdbserver stub, I sent the triple string as kalimba-csr-unknown. However the receiving code (GDBRemoteCommunicationClient) expects the string to be encoded as hex bytes, since '-' are a reserved GDB-RSP control character.
>> 
>> The documentation for qHostInfo in lldb-gdb-remote.txt does not allude to this at all. So I'm sending this patch which I think improves this state of affairs.
>> 
>> Could someone please apply this patch?
>> 
>> thanks Matt
>> 
>> 
>> Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
>> More information can be found at www.csr.com. Keep up to date with CSR on our technical blog, www.csr.com/blog, CSR people blog, www.csr.com/people, YouTube, www.youtube.com/user/CSRplc, Facebook, www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at www.twitter.com/CSR_plc.
>> New for 2014, you can now access the wide range of products powered by aptX at www.aptx.com.
>> <lldb-gdb-remote.patch>_______________________________________________
>> lldb-commits mailing list
>> lldb-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>