[Lldb-commits] [lldb] r213781 - Ensure that if some unspecified person were to pass in an invalid architecture when trying to create a target, that it would fail, but not cause LLDB to crash.

[Enrico Granata]

Author: enrico
Date: Wed Jul 23 13:18:38 2014
New Revision: 213781

URL: http://llvm.org/viewvc/llvm-project?rev=213781&view=rev
Log:
Ensure that if some unspecified person were to pass in an invalid architecture when trying to create a target, that it would fail, but not cause LLDB to crash.

Added:
    lldb/trunk/test/functionalities/nosucharch/
    lldb/trunk/test/functionalities/nosucharch/Makefile
    lldb/trunk/test/functionalities/nosucharch/TestNoSuchArch.py
    lldb/trunk/test/functionalities/nosucharch/main.cpp

Added: lldb/trunk/test/functionalities/nosucharch/Makefile
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/nosucharch/Makefile?rev=213781&view=auto
==============================================================================
--- lldb/trunk/test/functionalities/nosucharch/Makefile (added)
+++ lldb/trunk/test/functionalities/nosucharch/Makefile Wed Jul 23 13:18:38 2014
@@ -0,0 +1,5 @@
+LEVEL = ../../make
+
+CXX_SOURCES := main.cpp
+
+include $(LEVEL)/Makefile.rules

Added: lldb/trunk/test/functionalities/nosucharch/TestNoSuchArch.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/nosucharch/TestNoSuchArch.py?rev=213781&view=auto
==============================================================================
--- lldb/trunk/test/functionalities/nosucharch/TestNoSuchArch.py (added)
+++ lldb/trunk/test/functionalities/nosucharch/TestNoSuchArch.py Wed Jul 23 13:18:38 2014
@@ -0,0 +1,48 @@
+"""
+Test that using a non-existent architecture name does not crash LLDB.
+"""
+import lldb
+import unittest2
+from lldbtest import *
+import lldbutil
+
+class NoSuchArchTestCase(TestBase):
+
+    mydir = TestBase.compute_mydir(__file__)
+
+        
+    @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
+    @dsym_test
+    def test_with_dsym (self):
+        self.buildDsym()
+        self.do_test ()
+
+
+    @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
+    @dwarf_test
+    def test_with_dwarf (self):
+        self.buildDwarf()
+        self.do_test ()
+
+    def do_test (self):
+        exe = os.path.join (os.getcwd(), "a.out")
+        
+        # Check that passing an invalid arch via the command-line fails but doesn't crash
+        self.expect("target crete --arch nothingtoseehere %s" % (exe), error=True)
+        
+        
+        # Check that passing an invalid arch via the SB API fails but doesn't crash
+        target = self.dbg.CreateTargetWithFileAndArch(exe,"nothingtoseehere")
+        
+        self.assertFalse(target.IsValid(), "This target should not be valid")
+        
+        # Now just create the target with the default arch and check it's fine
+        target = self.dbg.CreateTarget(exe)
+        self.assertTrue(target.IsValid(), "This target should now be valid")
+
+if __name__ == '__main__':
+    import atexit
+    lldb.SBDebugger.Initialize()
+    atexit.register(lambda: lldb.SBDebugger.Terminate())
+    unittest2.main()
+

Added: lldb/trunk/test/functionalities/nosucharch/main.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/nosucharch/main.cpp?rev=213781&view=auto
==============================================================================
--- lldb/trunk/test/functionalities/nosucharch/main.cpp (added)
+++ lldb/trunk/test/functionalities/nosucharch/main.cpp Wed Jul 23 13:18:38 2014
@@ -0,0 +1,3 @@
+int main() {
+  return 0;
+}