[Lldb-commits] [lldb] r213716 - Plugins: silence a few more signed comparision warnings

Saleem Abdulrasool compnerd at compnerd.org
Tue Jul 22 18:53:55 PDT 2014


Author: compnerd
Date: Tue Jul 22 20:53:54 2014
New Revision: 213716

URL: http://llvm.org/viewvc/llvm-project?rev=213716&view=rev
Log:
Plugins: silence a few more signed comparision warnings

Address a few signed-compare warnings that were triggered on GCC 4.8.2.

Modified:
    lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp?rev=213716&r1=213715&r2=213716&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Tue Jul 22 20:53:54 2014
@@ -5426,7 +5426,8 @@ ObjectFileMachO::SaveCore (const lldb::P
                             // Now write the file data for all memory segments in the process
                             for (const auto &segment : segment_load_commands)
                             {
-                                if (segment.fileoff != core_file.SeekFromStart(segment.fileoff))
+                                off_t offset = core_file.SeekFromStart(segment.fileoff);
+                                if (offset < 0 || segment.fileoff != static_cast<uint64_t>(offset))
                                 {
                                     error.SetErrorStringWithFormat("unable to seek to offset 0x%" PRIx64 " in '%s'", segment.fileoff, core_file_path.c_str());
                                     break;





More information about the lldb-commits mailing list