[Lldb-commits] [PATCH] Mangled: Fix an 'unused variable' warning on GNU/Linux
Greg Clayton
gclayton at apple.com
Tue Jul 22 13:38:08 PDT 2014
Looks good.
> On Jul 22, 2014, at 1:19 PM, David Majnemer <david.majnemer at gmail.com> wrote:
>
> Hi zturner, tfiala,
>
> Platforms which don't use LLDB's built-in demangler don't use the
> 'mangled_length' variable. Instead, replace it's only use by an
> expression it is equivalent to.
>
> http://reviews.llvm.org/D4625
>
> Files:
> source/Core/Mangled.cpp
>
> Index: source/Core/Mangled.cpp
> ===================================================================
> --- source/Core/Mangled.cpp
> +++ source/Core/Mangled.cpp
> @@ -5158,7 +5158,6 @@
>
> // Don't bother running anything that isn't mangled
> const char *mangled_cstr = m_mangled.GetCString();
> - long mangled_length = m_mangled.GetLength();
> if (cstring_is_mangled(mangled_cstr))
> {
> if (!m_mangled.GetMangledCounterpart(m_demangled))
> @@ -5170,7 +5169,7 @@
> // performance win, falling back to the full demangler only
> // when necessary
> char *demangled_name = FastDemangle (mangled_cstr,
> - mangled_length);
> + m_mangled.GetLength());
> if (!demangled_name)
> demangled_name = __cxa_demangle (mangled_cstr, NULL, NULL, NULL);
> #elif defined(_MSC_VER)
> <D4625.11776.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
More information about the lldb-commits
mailing list