[Lldb-commits] [PATCH] [lldb] ASan malloc/free history threads

[Greg Clayton]

Looks good, just one more fix and you can commit. Change this:

    typedef MemoryHistory* (*MemoryHistoryCreateInstance) (const lldb::ProcessSP &process_sp);

To return a lldb::MemoryHistorySP instead of a MemoryHistory*. If MemoryHistory inherits from std::shared_from_this and you don't originally create it in a shared pointer the std::weak_ptr inside the 
std::shared_from_this in MemoryHistory won't initialized and std::shared_from_this functionality won't work.

Greg

> On Jul 21, 2014, at 3:50 PM, Kuba Brecka <kuba.brecka at gmail.com> wrote:
> 
> Changed the plugin name. Added a method into lldbtest.py that tries to locate Clang in the llvm-build directory, which is needed if your system compiler doesn't have ASan or it doesn't have the recent ASan debugging API.
> 
> http://reviews.llvm.org/D4596
> 
> Files:
>  include/lldb/Core/PluginManager.h
>  include/lldb/Target/MemoryHistory.h
>  include/lldb/lldb-forward.h
>  include/lldb/lldb-private-interfaces.h
>  lldb.xcodeproj/project.pbxproj
>  source/CMakeLists.txt
>  source/Commands/CommandObjectMemory.cpp
>  source/Core/PluginManager.cpp
>  source/Plugins/CMakeLists.txt
>  source/Plugins/Makefile
>  source/Plugins/MemoryHistory/CMakeLists.txt
>  source/Plugins/MemoryHistory/asan/CMakeLists.txt
>  source/Plugins/MemoryHistory/asan/Makefile
>  source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp
>  source/Plugins/MemoryHistory/asan/MemoryHistoryASan.h
>  source/Plugins/Process/Utility/HistoryThread.h
>  source/Target/CMakeLists.txt
>  source/Target/MemoryHistory.cpp
>  source/lldb.cpp
>  test/functionalities/asan/Makefile
>  test/functionalities/asan/TestAsan.py
>  test/functionalities/asan/main.c
>  test/lldbtest.py
> <D4596.11726.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits