[Lldb-commits] [lldb] r213643 - Fix the warnings introduced

Deepak Panickal deepak at codeplay.com
Tue Jul 22 04:59:11 PDT 2014


Author: panickal
Date: Tue Jul 22 06:59:11 2014
New Revision: 213643

URL: http://llvm.org/viewvc/llvm-project?rev=213643&view=rev
Log:
Fix the warnings introduced

Modified:
    lldb/trunk/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp
    lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp

Modified: lldb/trunk/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp?rev=213643&r1=213642&r2=213643&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp (original)
+++ lldb/trunk/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp Tue Jul 22 06:59:11 2014
@@ -244,7 +244,7 @@ ABISysV_hexagon::PrepareTrivialCall ( Th
     lldb::ProcessSP proc = thread.GetProcess( );
 
     // push host data onto target
-    for ( int i = 0; i < args.size( ); i++ )
+    for ( size_t i = 0; i < args.size( ); i++ )
     {
         const ABI::CallArgument &arg = args[i];
         // skip over target values
@@ -269,7 +269,7 @@ ABISysV_hexagon::PrepareTrivialCall ( Th
 
 #if HEX_ABI_DEBUG
     // print the original stack pointer
-    printf( "sp : %04x \n", sp );
+    printf( "sp : %04lx \n", sp );
 #endif
 
     // make sure number of parameters matches prototype
@@ -296,8 +296,6 @@ ABISysV_hexagon::PrepareTrivialCall ( Th
     // pass arguments that are passed via registers
     for ( int i = 0; i < nRegArgs; i++ )
     {
-        // get this parameter type
-        llvm::Type *argType = prototype.getFunctionParamType( i );
         // get the parameter as a u32
         uint32_t param = (uint32_t)args[i].value;
         // write argument into register
@@ -314,7 +312,7 @@ ABISysV_hexagon::PrepareTrivialCall ( Th
         sp -= 4;
 
     // arguments that are passed on the stack
-    for ( int i = nRegArgs, offs=0; i < args.size( ); i++ )
+    for ( size_t i = nRegArgs, offs=0; i < args.size( ); i++ )
     {
         // get the parameter as a u32
         uint32_t param = (uint32_t)args[i].value;
@@ -339,7 +337,7 @@ ABISysV_hexagon::PrepareTrivialCall ( Th
         uint32_t data = 0;
         lldb::addr_t addr = sp + i * 4;
         proc->ReadMemory( addr, (void*)&data, sizeof( data ), error );
-        printf( "\n0x%04x 0x%08x ", addr, data );
+        printf( "\n0x%04lx 0x%08x ", addr, data );
         if ( i == 0 ) printf( "<<-- sp" );
     }
     printf( "\n" );
@@ -348,18 +346,6 @@ ABISysV_hexagon::PrepareTrivialCall ( Th
     return true;
 }
 
-static bool
-ReadIntegerArgument ( Scalar &scalar,
-                      unsigned int bit_width,
-                      bool is_signed,
-                      Thread &thread,
-                      uint32_t *argument_register_ids,
-                      unsigned int &current_argument_register,
-                      addr_t &current_stack_argument)
-{
-    return false;
-}
-
 bool
 ABISysV_hexagon::GetArgumentValues ( Thread &thread, ValueList &values ) const
 {
@@ -565,4 +551,4 @@ ABISysV_hexagon::GetReturnValueObjectImp
         ConstString("")
     );
     return vObjSP;
-}
\ No newline at end of file
+}

Modified: lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp?rev=213643&r1=213642&r2=213643&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp Tue Jul 22 06:59:11 2014
@@ -56,9 +56,7 @@ static lldb::addr_t findSymbolAddress( P
     lldb_private::Symtab *symtab = exe->GetSymtab( );
     assert( symtab != nullptr );
 
-    int nSyms = symtab->GetNumSymbols( );
-
-    for ( int i = 0; i < symtab->GetNumSymbols( ); i++ )
+    for ( size_t i = 0; i < symtab->GetNumSymbols( ); i++ )
     {
         const Symbol* sym = symtab->SymbolAtIndex( i );
         assert( sym != nullptr );
@@ -403,7 +401,7 @@ DynamicLoaderHexagonDYLD::RendezvousBrea
             dyld_instance->m_rendezvous.SetRendezvousAddress( structAddr );
 
             if ( log )
-                log->Printf( "Found _rtld_debug structure @ 0x%08x", structAddr );
+                log->Printf( "Found _rtld_debug structure @ 0x%08lx", structAddr );
         }
         else
         {





More information about the lldb-commits mailing list