[Lldb-commits] [PATCH] Fix portability problems in lots of tests

[Zachary Turner]

Hi tfiala,

99% of this CL is simply moving calls to "import pexpect" to a more narrow scope - i.e. the function that actually runs a particular test.  This way the test suite can run on Windows, which doesn't have pexpect, and the individual tests that use pexpect can be disabled on a platform-specific basis.

There were a handful of other changes that address other portability issues.  Notably, using "ps" to get the command line (changed to use ' '.join(sys.argv)), and using os.uname() which isn't on Windows.

With this change, the only remaining piece of work left to be done to get the test suite fully working on Windows is to get the Win32 "builder module" working.

http://reviews.llvm.org/D4573

Files:
  test/benchmarks/disassembly/TestDisassembly.py
  test/benchmarks/disassembly/TestDoAttachThenDisassembly.py
  test/benchmarks/disassembly/TestXcode41Vs42GDBDisassembly.py
  test/benchmarks/expression/TestExpressionCmd.py
  test/benchmarks/expression/TestRepeatedExprs.py
  test/benchmarks/frame_variable/TestFrameVariableResponse.py
  test/benchmarks/startup/TestStartupDelays.py
  test/benchmarks/stepping/TestRunHooksThenSteppings.py
  test/benchmarks/stepping/TestSteppingSpeed.py
  test/benchmarks/turnaround/TestCompileRunToBreakpointTurnaround.py
  test/dotest.py
  test/functionalities/command_history/TestCommandHistory.py
  test/functionalities/command_regex/TestCommandRegex.py
  test/functionalities/completion/TestCompletion.py
  test/functionalities/connect_remote/TestConnectRemote.py
  test/functionalities/embedded_interpreter/TestConvenienceVariables.py
  test/functionalities/single-quote-in-filename-to-lldb/TestSingleQuoteInFilename.py
  test/functionalities/stop-hook/TestStopHookMechanism.py
  test/functionalities/stop-hook/multiple_threads/TestStopHookMultipleThreads.py
  test/macosx/add-dsym/TestAddDsymMidExecutionCommand.py
  test/python_api/interpreter/TestCommandInterpreterAPI.py
  test/python_api/sbdata/TestSBData.py
  test/settings/TestSettings.py
  test/terminal/TestSTTYBeforeAndAfter.py
  test/tools/lldb-gdbserver/gdbremote_testcase.py
  test/warnings/uuid/TestAddDsymCommand.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4573.11614.patch
Type: text/x-patch
Size: 17013 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140717/5b5585fb/attachment.bin>