[Lldb-commits] [PATCH] Submission request for the PlatformKalimba plugin

[Abid, Hafiz]

Sorry I meant source/CMakeLists.txt.

> -----Original Message-----
> From: lldb-commits-bounces at cs.uiuc.edu [mailto:lldb-commits-
> bounces at cs.uiuc.edu] On Behalf Of Abid, Hafiz
> Sent: 16 July 2014 13:34
> To: Matthew Gardiner; lldb-commits at cs.uiuc.edu
> Subject: Re: [Lldb-commits] [PATCH] Submission request for the
> PlatformKalimba plugin
> 
> Hi Matthew,
> You also need to add  lldbPluginPlatformKalimba to source/CMakefileList.txt.
> Otherwise cmake build will fail. After doing that your patch build OK for me
> on Linux with cmake. I have not tried autotools build though.
> 
> I will commit your patch later if there are no other comments.
> 
> Thanks,
> Abid
> 
> > -----Original Message-----
> > From: lldb-commits-bounces at cs.uiuc.edu [mailto:lldb-commits-
> > bounces at cs.uiuc.edu] On Behalf Of Matthew Gardiner
> > Sent: 16 July 2014 09:12
> > To: lldb-commits at cs.uiuc.edu
> > Subject: [Lldb-commits] [PATCH] Submission request for the
> > PlatformKalimba plugin
> >
> > Could somebody please submit this attached patch for me? It comprises
> > of additions and some minor changes in order that "kalimba" is listed
> > as a supported platform and that debugging any kalimbas results in
> > PlatformKalimba being associated with the target. They are as follows:
> >
> > * The PlatformKalimba implementation itself
> > * A tweak to ArchSpec
> > * .note parsing for Kalimba in ObjectFileELF.cpp
> > * Plugin registration
> > * Makefile additions
> >
> > Information regarding the proposed patch has been on lldb-dev for a
> > couple of days, and I believe that my latest amendments have not
> > generated any controversial feedback.
> >
> > thanks
> > Matt
> >
> >
> >
> > Member of the CSR plc group of companies. CSR plc registered in
> > England and Wales, registered number 4187346, registered office
> > Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4
> > 0WZ, United Kingdom More information can be found at www.csr.com.
> Keep
> > up to date with CSR on our technical blog, www.csr.com/blog, CSR
> > people blog, www.csr.com/people, YouTube,
> www.youtube.com/user/CSRplc,
> > Facebook, www.facebook.com/pages/CSR/191038434253534, or follow us
> on
> > Twitter at www.twitter.com/CSR_plc.
> > New for 2014, you can now access the wide range of products powered by
> > aptX at www.aptx.com.
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits