[Lldb-commits] [PATCH] ObjectFileELF::GetSectionHeaderInfo sets arch_spec unnecessarily

Ed Maste emaste at freebsd.org
Fri Jul 11 07:24:08 PDT 2014

On 10 July 2014 21:48, Todd Fiala <tfiala at google.com> wrote:
> Matthew,
> Your patch looks good to me. I would like Greg and/or Ed to have a look at it too. If they don’t object, I can submit it.
> I ran tests on Linux and MacOSX with the patch applied

The change LGTM and it passes on FreeBSD.

One little point to keep in mind is that there are ELF files that have
no section headers.  We should avoid (further) conflating
m_section_headers.empty() with having not yet parsed the header.

More information about the lldb-commits mailing list