[Lldb-commits] [PATCH] Invalidate process uid/gid command options on Windows

[Zachary Turner]

You're obviously much more familiar with the system than me, but at least
from my point of view it kind of makes sense.  Target platform is just
that, the target platform, which may not be the same as the selected
platform.  I suppose one way to formalize it would be to add "selected
platform" to the ExecutionContext.

Speaking of the ExecutionContext, I kind of dislike that it's stack-based
and returned by value.  Many parts of LLDB aren't really const-correct, and
returning by value necessitates passing it as to this method as a
const-reference, and it then becomes difficult to access some of its
functionality.  Not an issue in this particular CL, just an observation I
had.


On Mon, Jul 7, 2014 at 2:59 PM, <jingham at apple.com> wrote:

> This seems okay.  It bugs me a little that I can get the platform two ways
> now, from the target & from the explicit platform.  It only makes sense if
> the two are the same, but it would be nice if there were some way to
> formalize that...
>
> Jim
>
> > On Jul 7, 2014, at 1:21 PM, Zachary Turner <zturner at google.com> wrote:
> >
> > Update the patch to take both an ExecutionContext and a Platform
> independently of each other.  The core logic has not changed, this
> particular validator still goes through the Platform and ignores the
> Target, since there may be no target running.
> >
> > http://reviews.llvm.org/D4373
> >
> > Files:
> >  include/lldb/Host/OptionParser.h
> >  include/lldb/Interpreter/CommandOptionValidators.h
> >  include/lldb/Interpreter/Options.h
> >  include/lldb/lldb-private-types.h
> >  source/Commands/CommandObjectPlatform.cpp
> >  source/Interpreter/Args.cpp
> >  source/Interpreter/CMakeLists.txt
> >  source/Interpreter/CommandOptionValidators.cpp
> >  source/Interpreter/Options.cpp
> > <D4373.11127.patch>_______________________________________________
> > lldb-commits mailing list
> > lldb-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140707/7e49d84c/attachment.html>