[Lldb-commits] [PATCH] Allow specification of no source display on stop

[Randy Smith]

On Mon, Jul 7, 2014 at 2:33 PM, Greg Clayton <gclayton at apple.com> wrote:

> Looks fine to me if the test suite is happy with the changes.
>

No failures on Linux other than failures I've also seen on trunk
(TestConvenienceVariables.py is consistently failing on Linux for me).

Willing to land it for me?  This is my first patch, so unless I'm told
differently (:-}) I'm going with the LLVM process of submitting patches for
a while rather than asking for commit access up front.  (I do intend to
make multiple contributions to lldb over the coming weeks/months.)

Thanks!

-- Randy


> Greg
>
> > On Jul 3, 2014, at 11:42 AM, Randy Smith <rdsmith at chromium.org> wrote:
> >
> >
> > Based on r212225.  I've sketched out my rationale for this change in
> http://llvm.org/bugs/show_bug.cgi?id=20149.  It's fairly simple; is
> someone willing to take a look?
> >
> > Note that I don't (yet) have commit access, so if this patch is approved
> someone will need to land it for me.  (I found the LLVM and LLDB pages not
> completely consistent around the process for gaining commit access, so I'm
> going with the LLVM "contribute several patches and then ask".)
> >
> > I ran the "check-lldb" test suite on Linux, and found no difference in
> results between r212225 and r212225+my patch.  (As a side note, what should
> I expect from the Linux test suite?  TestConvenienceVariables.py is failing
> for me at top of tree.)
> >
> > -- Randy
> >
> > <sourcedisp.diff>_______________________________________________
> > lldb-commits mailing list
> > lldb-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140707/d5645a53/attachment.html>