[Lldb-commits] [PATCH] lldb - problem with some PTRACE_* constants in NativeProcessLinux.cpp file

Todd Fiala tfiala at google.com
Wed Jul 2 14:31:39 PDT 2014


Initially I was going to adjust the patch to pull out the PTRACE_* defines, but I'll leave them in for now based on this:

These things can be defined different ways for other architectures, e.g. for x86_64 Linux, asm/ptrace-abi.h defines them as preprocessor constants while sys/ptrace.h defines them in enum along with corresponding PT_* preprocessor constants

I'll have a deeper look at this after I get it running on a cross compiler and x86/x86_64/ARM/ARM64.  We may want to go ahead and just define these using known-to-be-correct values for the target but define them ourselves with non-colliding LLDB constants (for example, see the UnixSignals* hierarchy, which defines the values directly rather than pulling in system header values that are only correct for the compiler host or cross-compiler headers).

http://reviews.llvm.org/D4366






More information about the lldb-commits mailing list