[Lldb-commits] [PATCH] Reducing lldb Carbon footprint by replacing the only Carbon API call by Cocoa equivalent

[Jean-Daniel Dupas]

Done by r212208.

Le 2 juil. 2014 à 21:12, jingham at apple.com a écrit :

> 
> This code was pretty useful when we were first working on lldb and Xcode didn't support lldb.  But now that you can actually debug using lldb in Xcode, it is less clear that for Xcode as an external editor is all that useful.
> 
> Removing the Xcode support won't affect editors that support the BBEdit "open file at this line" Apple event, like BBEdit...  So I don't think it is a big loss.
> 
> Jim
> 
>> On Jul 2, 2014, at 11:43 AM, Jean-Daniel Dupas <devlists at shadowlab.org> wrote:
>> 
>> No, I didn't managed to get it working, so removing that code is probably a better solution.
>> 
>> I also though about rewriting it using the 'xed' command line tool with the '--line' argument, but it's broken too. It properly move the caret to the right line, but does not scroll the document.
>> 
>> 
>> Le 2 juil. 2014 à 20:29, jingham at apple.com a écrit :
>> 
>>> 
>>> Jean-Daniel,
>>> 
>>> Did you actually get this to work with a recent Xcode?  The last time I tried this, Xcode had broken the AS support for "set the selection" which rendered this whole bit of code moot.  I just hadn't gotten around to deleting it yet.  If you have it working, that is excellent!  But if it just opens the source file in Xcode, and doesn't hilight the source line - that's what the current code does - then Xcode still doesn't support the thing this code is trying to do and it is probably better to just delete the "if {using_xcode) " bit.
>>> 
>>> Jim
>>> 
>>> 
>>>> On Jul 2, 2014, at 11:03 AM, Jean-Daniel Dupas <devlists at shadowlab.org> wrote:
>>>> 
>>>> 
>>>> This patch removes the dependency on Carbon framework. 
>>>> 
>>>> The only Carbon API usage is a couple of call to OSA functions to execute an apple script in Host.mm.
>>>> This patch replaces OSA calls by using NSAppleScript instead.
>>>> 
>>>> Thanks
>>>> -- Jean-Daniel
>>>> 
>>>> 
>>>> 
>>>> <carbon.patch>_______________________________________________
>>>> lldb-commits mailing list
>>>> lldb-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>> 
>> 
>> -- Jean-Daniel
> 

-- Jean-Daniel