[Lldb-commits] [PATCH] Allow the path to the compiler to have spaces in it when running python test suite

[Zachary Turner]

Hi tfiala,

On Windows, the path to the compiler almost always contains a space.  Previously, we would just replace all spaces with semicolons to build a CMake list.  This patch changes the CMake to not do this replacement in the compiler path.

http://reviews.llvm.org/D4365

Files:
  test/CMakeLists.txt

Index: test/CMakeLists.txt
===================================================================
--- test/CMakeLists.txt
+++ test/CMakeLists.txt
@@ -11,15 +11,10 @@
     )
 endfunction()
 
-string(REGEX REPLACE ".*ccache\ +" "" LLDB_TEST_COMPILER ${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1})
+string(REGEX REPLACE ".*ccache\ +" "" LLDB_TEST_COMPILER \"${CMAKE_C_COMPILER}\" ${CMAKE_C_COMPILER_ARG1})
 
 # Users can override LLDB_TEST_ARGS to modify the way LLDB tests are run. See help below.
-set(LLDB_TEST_ARGS
-  -C
-  ${LLDB_TEST_COMPILER}
-  CACHE STRING "Specify compiler(s) and architecture(s) with which run LLDB tests. For example: '-C gcc -C clang -A i386 -A x86_64'"
-  )
-string(REPLACE " " ";" LLDB_TEST_ARGS ${LLDB_TEST_ARGS})
+STRING(REGEX REPLACE "\"" "\\\\\"" LLDB_TEST_ARGS "-C;${LLDB_TEST_COMPILER}")
 
 set(LLDB_TRACE_DIR "${CMAKE_BINARY_DIR}/lldb-test-traces"
   CACHE STRING "Set directory to output LLDB test traces (for tests that do not pass.)"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4365.11032.patch
Type: text/x-patch
Size: 969 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140702/ad5cec5d/attachment.bin>