[Lldb-commits] [PATCH] Update ObjectFileELF to detect ELF triple based on ELF notes and the ELF header.

Ed Maste emaste at freebsd.org
Thu Jun 26 18:44:03 PDT 2014


================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1101
@@ +1100,3 @@
+                uint32_t version_info;
+                if (data.GetU32 (&offset, &version_info, 1) == nullptr)
+                {
----------------
Should we validate that the descsz is as expected in here too?  E.g.  `(note.n_name == LLDB_NT_OWNER_FREEBSD && note.n_type == LLDB_NT_FREEBSD_ABI_TAG && note.n_descsz == 4)`

http://reviews.llvm.org/D4302






More information about the lldb-commits mailing list