[Lldb-commits] [PATCH] Update ObjectFileELF to detect ELF triple based on ELF notes and the ELF header.

Ed Maste emaste at freebsd.org
Thu Jun 26 10:07:48 PDT 2014


>> Also for the purpose of this parsing we'll generally have just one case in each of the switch statements - maybe it'd be more concise to just check note.n_type == LLDB_NT_FREEBSD_ABI_TAG in the if() as well?
>
> Sure, I think it's only GNU that is using multiple ones.   I can change that for the others.

Yeah - I was just hoping to lessen the bloat a bit for future
additions -- I suspect later ones will be (n_name == OpenBSD && n_type
== OPENBSD_ABI_TAG), n_name == DragonFly && n_type ==
DRAGONFLY_ABI_TAG), etc.. all following the same pattern.

http://reviews.llvm.org/D4302






More information about the lldb-commits mailing list