[Lldb-commits] [PATCH] Don't truncate the target triple when initializing clang

[Zachary Turner]

Hi tfiala,

Don't truncate the target triple when initializing clang.

Target triples support an optional 4th component, the environment.  Clang on Windows uses this 4th component to make various decisions when looking for header file includes, so truncating it leads to crashes on Windows when performing simple expression evaluation.

http://reviews.llvm.org/D4282

Files:
  source/Expression/ClangExpressionParser.cpp

Index: source/Expression/ClangExpressionParser.cpp
===================================================================
--- source/Expression/ClangExpressionParser.cpp
+++ source/Expression/ClangExpressionParser.cpp
@@ -129,19 +129,6 @@
     if (target_sp && target_sp->GetArchitecture().IsValid())
     {
         std::string triple = target_sp->GetArchitecture().GetTriple().str();
-        
-        int dash_count = 0;
-        for (size_t i = 0; i < triple.size(); ++i)
-        {
-            if (triple[i] == '-')
-                dash_count++;
-            if (dash_count == 3)
-            {
-                triple.resize(i);
-                break;
-            }
-        }
-        
         m_compiler->getTargetOpts().Triple = triple;
     }
     else
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4282.10813.patch
Type: text/x-patch
Size: 766 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140624/817196b9/attachment.bin>