[Lldb-commits] [PATCH] Add API control of the signal disposition.
Zachary Turner
zturner at google.com
Tue Jun 24 14:29:37 PDT 2014
Thanks. It looks like UnixSignals.cpp is compiled on Windows, therefore
this should too. For whatever reason, the list of files to compile for the
API are maintained in a different CMake location on Windows than on
non-Windows. So when adding a file to API, you need to add it in two
places. Don't revert, I'll just check in a fix that compiles on Windows.
Already tested it locally, just wanted to confirm your intent first.
On Tue, Jun 24, 2014 at 2:25 PM, Russell Harmon <eatnumber1 at google.com>
wrote:
> It should be just as platform dependant as the UnixSignals object it relies
> on. I didn't originally write it with windows in mind.
>
> What's standard procedure here? Rollback? Or fix forward?
>
> Without looking at the code, how does Windows deal with the UnixSignals
> object? Is it just not built?
>
> http://reviews.llvm.org/D4221
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140624/d7d42843/attachment.html>
More information about the lldb-commits
mailing list