[Lldb-commits] [lldb] r210682 - Restore select limitations comment for non-Apple platforms

[Ed Maste]

Author: emaste
Date: Wed Jun 11 13:10:41 2014
New Revision: 210682

URL: http://llvm.org/viewvc/llvm-project?rev=210682&view=rev
Log:
Restore select limitations comment for non-Apple platforms


Modified:
    lldb/trunk/source/Core/ConnectionFileDescriptor.cpp

Modified: lldb/trunk/source/Core/ConnectionFileDescriptor.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ConnectionFileDescriptor.cpp?rev=210682&r1=210681&r2=210682&view=diff
==============================================================================
--- lldb/trunk/source/Core/ConnectionFileDescriptor.cpp (original)
+++ lldb/trunk/source/Core/ConnectionFileDescriptor.cpp Wed Jun 11 13:10:41 2014
@@ -714,6 +714,12 @@ ConnectionFileDescriptor::Write (const v
 //  - The Apple specific version allows for unlimited fds in the fd_sets by
 //    setting the _DARWIN_UNLIMITED_SELECT define prior to including the
 //    required header files.
+// CONS:
+//  - on non-Apple platforms, only supports file descriptors up to FD_SETSIZE.
+//     This implementation  will assert if it runs into that hard limit to let
+//     users know that another ConnectionFileDescriptor::BytesAvailable() should
+//     be used or a new version of ConnectionFileDescriptor::BytesAvailable()
+//     should be written for the system that is running into the limitations.
 
 #if defined(__APPLE__)
 #define FD_SET_DATA(fds) fds.data()