[Lldb-commits] [PATCH] Fix the remainder of warnings for the Windows build.
Zachary Turner
zturner at google.com
Mon Jun 2 08:55:48 PDT 2014
Added comment explaining the use of size_t instead of offset_t.
http://reviews.llvm.org/D3944
Files:
include/lldb/Core/DataBufferMemoryMap.h
Index: include/lldb/Core/DataBufferMemoryMap.h
===================================================================
--- include/lldb/Core/DataBufferMemoryMap.h
+++ include/lldb/Core/DataBufferMemoryMap.h
@@ -100,7 +100,12 @@
/// @param[in] length
/// The size in bytes that should be mapped starting \a offset
/// bytes into the file. If \a length is \c SIZE_MAX, map
- /// as many bytes as possible.
+ /// as many bytes as possible. Even though it may be possible
+ /// for a 32-bit host debugger to debug a 64-bit target, size_t
+ /// still dictates the maximum possible size that can be mapped
+ /// into this process. For this kind of cross-arch debugging
+ /// scenario, mappings and views should be managed at a higher
+ /// level.
///
/// @return
/// The number of bytes mapped starting from the \a offset.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3944.10022.patch
Type: text/x-patch
Size: 906 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140602/81c57ec2/attachment.bin>
More information about the lldb-commits
mailing list