[Lldb-commits] [PATCH] Fix the remainder of warnings for the Windows build.
tfiala at google.com
Thu May 29 15:26:34 PDT 2014
I have a few comments on the data type changes above.
Let me know if you can address that and still get your warnings fixed.
Comment at: include/lldb/Core/DataBufferMemoryMap.h:111
@@ -110,3 +110,3 @@
lldb::offset_t offset = 0,
- lldb::offset_t length = SIZE_MAX,
+ size_t length = SIZE_MAX,
bool writeable = false);
I think you may need to do something more like:
lldb::offset_t length = std::numeric_limits<lldb::offset_t>::max().
MacOSX/iOS have cases where 32-bit code debugs 64-bit code, and in cases like that using the host data types does the wrong thing. I'd keep it lldb::offset_t and just fix the warning by what I suspect is the real issue, which is using SIZE_MAX as the initializer.
Comment at: include/lldb/Core/DataBufferMemoryMap.h:140
@@ -139,3 +139,3 @@
- lldb::offset_t length,
+ size_t length,
Likewise, keep this one lldb::offset_t.
Comment at: source/Core/DataBufferMemoryMap.cpp:129
@@ -126,3 +128,3 @@
This disappears with change to keep lldb::offset_t
More information about the lldb-commits