[Lldb-commits] [PATCH] Fix minor issues related to trying to run check-lldb on Windows

Scott Graham scottmg at chromium.org
Fri May 23 18:04:47 PDT 2014


Hi,

Otherwise, when running the test suite on Windows:
- dotest.py will be opened in an editor instead of executed
- once running there'll be errors of the form ".../build/bin/lldb is
not an executable"

Thanks!
-------------- next part --------------
Index: test/dosep.ty
===================================================================
--- test/dosep.ty	(revision 209562)
+++ test/dosep.ty	(working copy)
@@ -11,7 +11,7 @@
 from optparse import OptionParser
 
 # Command template of the invocation of the test driver.
-template = '%s/dotest.py %s -p %s %s'
+template = '%s %s/dotest.py %s -p %s %s'
 
 def process_dir(root, files, test_root, dotest_options):
     """Examine a directory for tests, and invoke any found within it."""
@@ -28,7 +28,7 @@
         if os.path.islink(path):
             continue
 
-        command = template % (test_root, dotest_options if dotest_options else "", name, root)
+        command = template % (sys.executable, test_root, dotest_options if dotest_options else "", name, root)
         if 0 != os.system(command):
             failed.append(name)
         else:
Index: test/CMakeLists.txt
===================================================================
--- test/CMakeLists.txt	(revision 209562)
+++ test/CMakeLists.txt	(working copy)
@@ -27,7 +27,7 @@
 
 set(LLDB_COMMON_TEST_ARGS
   --executable
-  ${CMAKE_BINARY_DIR}/bin/lldb
+  ${CMAKE_BINARY_DIR}/bin/lldb${CMAKE_EXECUTABLE_SUFFIX}
   -s
   ${LLDB_TRACE_DIR}
   -u CXXFLAGS


More information about the lldb-commits mailing list