[Lldb-commits] [lldb] r209108 - Add support for gdb remote $X stop notification.

[Todd Fiala]

Author: tfiala
Date: Sun May 18 23:57:23 2014
New Revision: 209108

URL: http://llvm.org/viewvc/llvm-project?rev=209108&view=rev
Log:
Add support for gdb remote $X stop notification.

debugserver now returns $X09 as the immediate response to
a $k kill process request rather than $W09.

ProcessGDBRemote now properly handles X as indication of
a process exit state.

The @debugserver_test and @lldb_test for $k now properly expects
an X notification (signal-caused exit) after killing a just-attached
inferior that was still in the stopped state.

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    lldb/trunk/test/tools/lldb-gdbserver/TestLldbGdbServer.py
    lldb/trunk/tools/debugserver/source/RNBRemote.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=209108&r1=209107&r2=209108&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Sun May 18 23:57:23 2014
@@ -1799,6 +1799,7 @@ ProcessGDBRemote::SetThreadStopInfo (Str
         break;
 
     case 'W':
+    case 'X':
         // process exited
         return eStateExited;
 

Modified: lldb/trunk/test/tools/lldb-gdbserver/TestLldbGdbServer.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/tools/lldb-gdbserver/TestLldbGdbServer.py?rev=209108&r1=209107&r2=209108&view=diff
==============================================================================
--- lldb/trunk/test/tools/lldb-gdbserver/TestLldbGdbServer.py (original)
+++ lldb/trunk/test/tools/lldb-gdbserver/TestLldbGdbServer.py Sun May 18 23:57:23 2014
@@ -496,7 +496,7 @@ class LldbGdbServerTestCase(TestBase):
         self.add_get_pid()
         self.test_sequence.add_log_lines(
             ["read packet: $k#6b",
-             "send packet: $W09#00"],
+             "send packet: $X09#00"],
             True)
         self.expect_gdbremote_sequence()
 

Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/RNBRemote.cpp?rev=209108&r1=209107&r2=209108&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/RNBRemote.cpp (original)
+++ lldb/trunk/tools/debugserver/source/RNBRemote.cpp Sun May 18 23:57:23 2014
@@ -3770,7 +3770,7 @@ RNBRemote::HandlePacket_k (const char *p
     // No response to should be sent to the kill packet
     if (m_ctx.HasValidProcessID())
         DNBProcessKill (m_ctx.ProcessID());
-    SendPacket ("W09");
+    SendPacket ("X09");
     return rnb_success;
 }