[Lldb-commits] [PATCH] Use SmallPtrSet in ClusterManager

[Todd Fiala]

Don't hold on my account, Scott.  It looked good to me from site, and based
on Jim's buddy run, all good from me.


On Fri, May 16, 2014 at 12:26 PM, <jingham at apple.com> wrote:

> I got the same result.  This patch is much more likely to cause crashes
> than failures if it was wrong, and I didn't see that either.  And the patch
> looks reasonable.  I say check it in.
>
> Jim
>
> On May 16, 2014, at 12:23 PM, Scott Knight <knightsc at gmail.com> wrote:
>
> > I did go ahead and run dotest.py this morning both before and after
> applying the patch and it seems to have the same 10 failures before and
> after like you mentioned. Another set of eyes checking the test results
> would be great though.
> >
> > http://reviews.llvm.org/D3616
> >
> >
> >
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140516/df6f6b6a/attachment.html>