[Lldb-commits] [PATCH] debugserver response to $k with incorrect code

[Greg Clayton]

Looks fine. Just be sure that all code that looks for 'W' also handles 'X'. I see some code in ProcessGDBRemote which handles 'W' but not 'X' (in ProcessGDBRemote::SetThreadStopInfo (StringExtractor& stop_packet)).

> On May 14, 2014, at 4:38 PM, Todd Fiala <todd.fiala at gmail.com> wrote:
> 
> Hey guys,
> 
> Debugserver is responding to a $k kill process command with W09 rather than X09 (i.e. indicating a normal exit with return code 9 rather than a signal-based exit from signal 9).  Any issue with me changing that?  I've tested it locally and it doesn't appear to cause any harm.  lldb still picks up the exit signal.
> 
> Thanks!
> 
> --- tools/debugserver/source/RNBRemote.cpp	(revision 208785)
> +++ tools/debugserver/source/RNBRemote.cpp	(working copy)
> @@ -3770,7 +3770,7 @@
>      // No response to should be sent to the kill packet
>      if (m_ctx.HasValidProcessID())
>          DNBProcessKill (m_ctx.ProcessID());
> -    SendPacket ("W09");
> +    SendPacket ("X09");
>      return rnb_success;
>  }
> 
> -- 
> -Todd
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits